Conversation
… ones When a class using a trait reports its own error with the same message and identifier as an error deduplicated directly into the trait, --generate-baseline records the class occurrence under the class path (count: 1) and the deduplicated error under the trait path (count: 1). On re-run the class-pathed entry also absorbed the trait context of that class, so it was reported as expected 1 time but occurred 2 times: the generated baseline failed by itself. An entry scoped to the trait file hides the deduplicated error for every using class, so it is now tried first: the class-pathed entries account only for the errors reported in the class files themselves. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
a53c4e2 to
e11628c
Compare
|
The problem this PR fixes, in short: a freshly generated baseline fails on the very next run. With the provided test files, (the trait error is reported once, although the trait is used by two classes).
Then because the trait error, when checked against the ignore entries, is also matched as an error of With this patch, the |
1 participant
When a class using a trait reports its own error with the same message and identifier as an error deduplicated directly into the trait,
--generate-baselinerecords the class occurrence under the class path (count: 1) and the deduplicated error under the trait path (count: 1)On re-run the class-pathed entry also absorbed the trait context of that class, so it was reported as expected 1 time but occurred 2 times: the generated baseline failed by itself.
An entry scoped to the trait file hides the deduplicated error for every using class, so it is now tried first: the class-pathed entries account only for the errors reported in the class files themselves.